Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthrough약관 엔티티에서 Changes
Sequence Diagram(s)sequenceDiagram
actor Client
participant TermService
participant LocaleContextHolder
participant TermRepository
participant TermTranslationRepository
participant TermsResponse
Client->>TermService: getTerms()
TermService->>LocaleContextHolder: 언어 코드 조회<br/>(full tag, base lang, "ko")
LocaleContextHolder-->>TermService: 우선순위 언어 목록
TermService->>TermRepository: getActiveTerms()
TermRepository-->>TermService: 활성 Term 목록
alt 활성 약관 없음
TermService-->>Client: 빈 TermsResponse
else 활성 약관 있음
TermService->>TermTranslationRepository: findAllByTerm_IdInAndLanguageCode<br/>(termIds, 우선순위 언어들)
TermTranslationRepository-->>TermService: TermTranslation 레코드들
TermService->>TermService: 언어별/termId별 그룹화<br/>우선순위 번역 선택<br/>(미존재 시 빈 값 fallback)
TermService->>TermsResponse: TermResponse.of()<br/>(term, title, content)
TermsResponse-->>Client: 다국어 번역이 포함된<br/>TermsResponse
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description 📝
ScreenShots 📷
To Reviewers 📢
Summary by CodeRabbit
주요 변경사항